Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT]: Custom route for Azure Function Webhooks #616

Closed
1 task done
raduorban opened this issue Dec 2, 2024 · 3 comments
Closed
1 task done

[FEAT]: Custom route for Azure Function Webhooks #616

raduorban opened this issue Dec 2, 2024 · 3 comments
Labels
Status: Triage This is being looked at and prioritized Type: Feature New feature or request

Comments

@raduorban
Copy link

Describe the need

Hi,

The route of the Azure function webhook is currently fixed, set in the HttpTrigger attribute. Would be useful to be able to specify custom route when calling ConfigureGitHubWebhooks (atm you canonly specify the secret).

image

Thanks :)

SDK Version

No response

API Version

No response

Relevant log output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@raduorban raduorban added Status: Triage This is being looked at and prioritized Type: Feature New feature or request labels Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@JamieMagee
Copy link
Contributor

The route location is defined in an attribute, and all attributes must be known to the compiler at compile time. I can't think of an easy way to configure this, but I'm open to contributions if you know a way.

@raduorban
Copy link
Author

Hi,

Thanks for the quick responses :) Seems indeed difficult, thanks for explaining :) Not an important feature atm. Thanks :)

@JamieMagee JamieMagee closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Feature New feature or request
Projects
Status: Done
Development

No branches or pull requests

2 participants