Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky tests for removal of items #1

Open
abulvenz opened this issue Dec 18, 2018 · 1 comment
Open

Flaky tests for removal of items #1

abulvenz opened this issue Dec 18, 2018 · 1 comment
Assignees

Comments

@abulvenz
Copy link

Hi there,

Thanks for sharing your code kata. The structure looks really nice.
However, when running the tests they sometimes fail. On my machine for bills and products.

Maybe its located around this lines, because only the retrieval of items is waited for, but not for the removal.

const billList = await models.Bill.findAll();
billList.forEach(bill => bill.destroy());

Since it's a racing condition maybe you didn't encounter it.

Best
Andi

@Falinor
Copy link

Falinor commented Mar 14, 2019

Hi Andi,

Thanks for noticing this issue and sorry for the late answer. We've all been pretty much busy.
I ran the tests hundreds of times to finally catch a failing one. Machines are so fast nowadays that we struggle to find this kind of bug.
I am going to propose a fix.

Best regards

@Falinor Falinor self-assigned this Mar 14, 2019
Falinor pushed a commit that referenced this issue Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants