Skip to content
This repository has been archived by the owner on Dec 5, 2020. It is now read-only.

Changes Or Notices To Use/Not Use In Production #4

Open
alexfinnarn opened this issue Feb 7, 2019 · 1 comment
Open

Changes Or Notices To Use/Not Use In Production #4

alexfinnarn opened this issue Feb 7, 2019 · 1 comment

Comments

@alexfinnarn
Copy link

When I saw https://github.com/weknowinc/drupal-boina/blob/master/scripts/composer/ScriptHandler.php#L57 I thought that the recommended setting was 755. I've certainly 777ed a lot of things on my local machine but in some cases could users deploy this setup to production with the same permissions?

If this is a perceived problem, then an update to the readme would suffice on what you would need to consider when moving this starter project to production. Even if projects are stated as "demos" someone will always ignore that and deploy it as-is anyway.

@jmolivas
Copy link
Contributor

We based the project on drupal-composer/drupal-project
https://github.com/drupal-composer/drupal-project/blob/8.x/scripts/composer/ScriptHandler.php#L57

Agree on make a note to let know user the suggested permissions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants