Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

obconnector-c/cmake/ConnectorName.cmake with invalid syntax #3

Open
hnwyllmm opened this issue Jul 20, 2021 · 1 comment
Open

obconnector-c/cmake/ConnectorName.cmake with invalid syntax #3

hnwyllmm opened this issue Jul 20, 2021 · 1 comment

Comments

@hnwyllmm
Copy link

In the file

https://github.com/oceanbase/obconnector-c/blob/68b3a78ce723bfe4e34012c886730cfb12aaedf3/cmake/ConnectorName.cmake
IF(CMAKE_SYSTEM_NAME MATCHES "Windows")
  SET(PLATFORM_NAME "win")
  SET(CONCAT_SIGN "")
  IF(IS64)
    SET(MACHINE_NAME "x64")
  ELSE()
    SET(MACHINE_NAME "32")
  END()    # should be ENDIF 
ENDIF()
@kongchengzhuge
Copy link
Contributor

Yes, there is indeed a problem here. It would be better to use ENDIF. In some specific cmake versions, no error will be reported here, but some lower versions of cmake will report an error here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants