Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maintain deep expanded state. #12

Open
mbostock opened this issue May 21, 2018 · 1 comment · Fixed by observablehq/framework#1475
Open

Maintain deep expanded state. #12

mbostock opened this issue May 21, 2018 · 1 comment · Fixed by observablehq/framework#1475

Comments

@mbostock
Copy link
Member

From observablehq/notebook#201:

collapse

Inspector collapse/expand state is maintained on the top level, but not when those inspectors are nested. Ideally we can maintain as much expanded/collapsed state as possible: clearest way to do this would be to maintain a list of expanded keypaths, and expand them when there's new output.
@mbostock mbostock mentioned this issue May 21, 2018
Closed
@mbostock mbostock mentioned this issue Jun 13, 2024
Closed
Fil added a commit to observablehq/framework that referenced this issue Jun 20, 2024
@Fil
expand the inspector if its previous version was expanded
7bf74c4 
this should be revised more thoroughly when we fix observablehq/inspector#12

closes #1458
@Fil Fil mentioned this issue Jun 20, 2024
Merged
mbostock added a commit to observablehq/framework that referenced this issue Jul 30, 2024
@Fil @mbostock
expand the inspector if its previous version was expanded (#1475)
ee49233 
* expand the inspector if its previous version was expanded
this should be revised more thoroughly when we fix observablehq/inspector#12

closes #1458

* fix multiple display; apply suggestions from code review

* fix comment

* preserve deep expanded state

* handle missing expanded state

---------

Co-authored-by: Mike Bostock <[email protected]>
@mbostock
Copy link
Member Author

This has been fixed in Observable Framework (1.10.0) but we haven’t implemented a fix for notebooks yet.

@mbostock mbostock reopened this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

expand the inspector if its previous version was expanded observablehq/framework
1 participant
@mbostock