Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JLCPCB-specific fabrication outputs #29

Closed
kroesche opened this issue Sep 23, 2021 · 4 comments
Closed

Add JLCPCB-specific fabrication outputs #29

kroesche opened this issue Sep 23, 2021 · 4 comments

Comments

@kroesche
Copy link
Contributor

As discussed here: #27

I will work on a PR for this feature. I created this issue to have a place to track it and have any further discussion about it.

conversation summary from obra:

"I'd also love a PR to add explicit generation steps for jlcpcb (and any other pcb house), maybe integrating https://github.com/matthewlai/JLCKicadTools for JLC."

AND

"I think that in my ideal world, everything would go into the docker container. That's part of the point of having Docker there at all - getting a known-good environment that should work cross-platform.

What I'm envisioning is a new makefile target of something like

make fabrication-output-jlcpcb

that would create the zipfile, the BOM and the placement file."

@kroesche
Copy link
Contributor Author

I am working on this one first, and then I will look at #30.

@kroesche
Copy link
Contributor Author

@obra I pretty much have completed this work in my own branch. However, I realize that there is still a file that I have to manually generate before you can run the new stuff to generate the JLCPCB parts files. Per the JLCKicadTools, you first have to use pcbnew to generate a footprint position file.

Up to now, for my own projects, this is what I have done. I generate the position file using pcbnew UI. Then I quit kicad and run the rest of the automation scripts. Obviously, this step should also be automated. However, it will require putting new stuff in kicad-automation-scripts to click all the right menus and buttons in pcbnew UI to generate that file.

I also took a look at KiAuto (the fork of your kicad-automation-scripts) just in case he already added it there, but I didn't see it.

How would you like to see this resolved? I can take a run at it in kicad-automation-scripts, although I am not very familiar at all with the kicad API, I can use what is already there as a model. Or, you expressed interest in replacing nicad-automation-scripts with KiAuto, so maybe that is where the effort should be focused first?

I can also go ahead and make the PR with what I have now if that is helpful.

@obra
Copy link
Owner

obra commented Sep 29, 2021

It looks like KiBot can now do .pos files. It may be time for us to jump from kiplot to kibot? (I'm fine with that happening after the initial merge.)

@kroesche
Copy link
Contributor Author

kroesche commented Oct 2, 2021

I think this can be closed.

@obra obra closed this as completed Oct 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants