Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uberon release v2024-11-25 #3435

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Uberon release v2024-11-25 #3435

merged 2 commits into from
Nov 26, 2024

Conversation

aleixpuigb
Copy link
Collaborator

No description provided.

@aleixpuigb aleixpuigb self-assigned this Nov 25, 2024
Copy link

github-actions bot commented Nov 25, 2024

@aleixpuigb aleixpuigb requested a review from rays22 November 25, 2024 15:54
relationship: has_role CHEBI:75771 ! mouse metabolite
relationship: has_role CHEBI:77941 ! EC 3.5.1.4 (amidase) inhibitor
relationship: has_role CHEBI:78433 ! refrigerant
relationship: RO:0000087 CHEBI:228364 ! has role NMR chemical shift reference compound
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For information: I believe those changes, and all similar changes in that file, are a normal and expected consequence of 61e7f2f. We no longer automatically create “shorthands” (such as has_role) for every single RO relation, so in the OBO release products the relations appear with their CURIEs instead.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Likewise for all the similar changes in uberon.obo.

rays22
rays22 previously approved these changes Nov 25, 2024
Copy link
Collaborator

@rays22 rays22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@aleixpuigb
Copy link
Collaborator Author

Is the creation of the file uberon-lastbuild.obo expected? I didn't see in previous Uberon releases. I am trying to find where does it come from.

@gouttegd
Copy link
Collaborator

@aleixpuigb It’s a consequence of #3377. The creation of the file is normal, but it is probably best to avoid committing it to the repository. You can remove it, and then avoid re-committing it in the future, you can add the following line to the .gitignore file:

uberon-lastbuild.obo

(There is already a similar line to avoid committing uberon-lastbuild.owl, but the OBO version was somehow forgotten.)

@aleixpuigb
Copy link
Collaborator Author

Thank you, I will do that.

Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

@aleixpuigb aleixpuigb merged commit 53f9ca5 into master Nov 26, 2024
2 checks passed
@aleixpuigb aleixpuigb deleted the release-2024-11-25 branch November 26, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants