Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses #3096 NTR pulmonary venule #3098

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Conversation

aleixpuigb
Copy link
Collaborator

Addresses #3096 NTR pulmonary venule

Addresses #3096 NTR pulmonary venule
@aleixpuigb aleixpuigb self-assigned this Oct 24, 2023
@aleixpuigb aleixpuigb linked an issue Oct 24, 2023 that may be closed by this pull request
@aleixpuigb aleixpuigb requested a review from a user October 24, 2023 13:56
[Term]
id: UBERON:8600024
name: pulmonary venule
def: "A venule that is part of a lung and drains oxygenated blood from pulmonary capillaries. A pulmonary venule merges into a pulmonary vein branch that run in the pulmonary interlobular septa." [PMID:22283705, PMID:30247823]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def: "A venule that is part of a lung and drains oxygenated blood from pulmonary capillaries. A pulmonary venule merges into a pulmonary vein branch that run in the pulmonary interlobular septa." [PMID:22283705, PMID:30247823]
def: "A venule that is part of a lung and drains oxygenated blood from pulmonary capillaries. A pulmonary venule merges into a pulmonary vein branch that runs in the pulmonary interlobular septa." [PMID:22283705, PMID:30247823]

This sounds like a "pulmonary vein branch", not a pulmonary venule, passes through a pulmonary interlobular septum. Is that aligned with the comment here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, I have to edit interlobular septa accordingly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A new ticket #3115 has been opened to correct this.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comment.
Also, with the current modelling, this class does not seem to be related to 'pulmonary venous system'. Consider if it should be.

@aleixpuigb aleixpuigb requested a review from a user November 14, 2023 12:51
@aleixpuigb
Copy link
Collaborator Author

See inline comment. Also, with the current modelling, this class does not seem to be related to 'pulmonary venous system'. Consider if it should be.

Thank you for your suggestion, I have added 'part of' some 'pulmonary venous system'.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No breaking changes found.
Defer content review to SME. After a cursory online review, there does not seem to be consensus on pulmonary venous vasculature terminology.

@aleixpuigb aleixpuigb merged commit a94b4df into master Nov 16, 2023
1 check passed
@aleixpuigb aleixpuigb deleted the 3096_NTR_pulmonary_venule branch November 16, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NTR] pulmonary venule
1 participant