Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace type definition for plural form synonyms #3083

Merged
merged 15 commits into from
Oct 27, 2023

Conversation

cthoyt
Copy link
Contributor

@cthoyt cthoyt commented Oct 1, 2023

Closes #3080 by replacing the ad-hod "plural" synonym type definition with the equivalent, externally defined OMO:0003004

Depends on

Closes obophenotype#3058 and closes obophenotype#3080 (duplicate of obophenotype#3058) by replacing the ad-hod "plural" synonym type definition with the equivalent, externally defined OMO:0003004
@anitacaron
Copy link
Collaborator

Wait for #3087 to be merged.

@anitacaron
Copy link
Collaborator

Also, it needs to wait for #3058

@anitacaron
Copy link
Collaborator

Need to remove the annotation obo:uberon/core#PLURAL

ERROR	missing_synonymtype_declaration	obo:uberon/core#PLURAL	rdfs:subPropertyOf	

@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 12, 2023

Can you please point me towards the file that is the "core" document?

@anitacaron
Copy link
Collaborator

Actually, you missed one term:

[Term]
id: UBERON:0008874
name: pulmonary acinus
def: "The largest lung subunit in which all airways participate in gas exchange, and it is composed of the parenchyma of the respiratory bronchioles, alveolar ducts, and alveoli." [MP:0010911, PMID:2014492, PMID:3382030, Wikipedia:Acinus#The_Lungs]
subset: pheno_slim
synonym: "acinus pulmonaris" EXACT LATIN [FMA:7313, FMA:TA]
synonym: "arbor alveolaris" EXACT LATIN [FMA:7313, FMA:TA]
>>synonym: "pulmonary acini" EXACT PLURAL [PMID:37025383]<<

@cthoyt
Copy link
Contributor Author

cthoyt commented Oct 17, 2023

@anitacaron fixed in a2576a4

@anitacaron anitacaron merged commit c5b5a32 into obophenotype:master Oct 27, 2023
1 check passed
@cthoyt cthoyt deleted the update-plurals branch October 27, 2023 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardise annotation property: 'plural form' (UBERON)
2 participants