Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import ORCIDIO #3071

Merged
merged 2 commits into from
Sep 18, 2023
Merged

Import ORCIDIO #3071

merged 2 commits into from
Sep 18, 2023

Conversation

anitacaron
Copy link
Collaborator

Documentation about ORCIDIO

@anitacaron anitacaron self-assigned this Sep 18, 2023
gouttegd
gouttegd requested changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for the exclusion of the src/ontology/imports/orcidio_terms.txt.

.gitignore Outdated Show resolved Hide resolved
@anitacaron anitacaron requested a review from gouttegd September 18, 2023 09:21
gouttegd
gouttegd approved these changes Sep 18, 2023
View reviewed changes
Copy link
Collaborator

@gouttegd gouttegd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks all good to me.

@anitacaron anitacaron merged commit 7f3c6fa into master Sep 18, 2023
1 check passed
@anitacaron anitacaron deleted the import-orcidio branch September 18, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gouttegd gouttegd gouttegd approved these changes

@matentzn matentzn Awaiting requested review from matentzn matentzn is a code owner

Assignees

@anitacaron anitacaron

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anitacaron @gouttegd