Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3049 Classify 'endocrine system' as a 'non-connected functional system'. #3050

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

gouttegd
Copy link
Collaborator

'endocrine system' is currently a dangling term with no explicit parent, so we (re-)classify it as a 'non-connected functional system' (as it used to be before the removal of its former logical definition).

closes #3049

'endocrine system' is currently a dangling term with no explicit parent,
so we (re-)classify it as a 'non-connected functional system' (as it
used to be before the removal of its former logical definition).

closes #3049
@gouttegd gouttegd self-assigned this Aug 31, 2023
@gouttegd gouttegd requested review from aleixpuigb and a user August 31, 2023 16:23
Copy link
Collaborator

@aleixpuigb aleixpuigb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for spotting this, @gouttegd.

@@ -8749,6 +8749,7 @@ xref: VHOG:0000098
xref: Wikipedia:Endocrine_system
xref: XAO:0000158
xref: ZFA:0001158
is_a: UBERON:0015203 ! non-connected functional system
Copy link

@ghost ghost Sep 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #3043, the 'neuroendocrine system' is classified as an 'anatomical system', which has a text def asserting it to be a "connected anatomical structure".

The definition of the PATO class disconnected is "A structural quality inhering in the bearer by virtue of the bearer consisting of multiple structures lacking any physical connection to each other."

I'm not sure if the above means at a single instant in time. If not, one may argue that physically distant structures of the (neuro)endocrine system are connected over time via the release and binding of hormones, neurotransmitters, etc.

Either way, 'endocrine system' and neuroendocrine system' should be modelled similarly.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree that however “endocrine system” is classified, “neuroendocrine system” should be classified similarly.

FWIW, I think interpreting “connected” as “connected over space OR time” is a bit of a stretch, especially since there is nothing in the definition of all the related terms that could suggest such a meaning. For example, anatomical structure (which in Uberon is the root class for all things connected – including anatomical system) is defined as “material anatomical entity that is a single connected structure with inherent 3D shape” – I don’t see how this leaves room for involving time.

In any case, the connected vs disconnected issue has been a regular source of unsatisfiability (especially when merging Uberon with other ontologies, because some other ontologies not only have a distinction between connected and disconnected but also enforce that distinction through disjointness axioms, something that Uberon does not), so any change to the meaning of “(dis)connected” should be discussed carefully in a dedicated ticket.

This PR merely restores “endocrine system” as a “non-connected functional system”, as it was until last week.

@gouttegd gouttegd merged commit ef511fa into master Sep 1, 2023
1 check passed
@gouttegd gouttegd deleted the 3049-fix-endocrine-system-classification branch September 1, 2023 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'endocrine system' has no explicit parent
2 participants