Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CL release 2023-10-19 #2205

Merged
1 commit merged into from
Oct 19, 2023
Merged

CL release 2023-10-19 #2205

1 commit merged into from
Oct 19, 2023

Conversation

ghost
Copy link

@ghost ghost commented Oct 19, 2023

CL release 2023-10-19

Cursory review revealed expected updates.

@ghost ghost self-assigned this Oct 19, 2023
@github-actions
Copy link

@ghost ghost requested review from anitacaron, gouttegd and aleixpuigb October 19, 2023 11:44
@ghost
Copy link
Author

ghost commented Oct 19, 2023

FYI @gouttegd as I noticed some edits involving "namespace: fly_anatomy.ontology".

@gouttegd
Copy link
Collaborator

The disappearance of the oboInOwl#hasOBONamespace annotations with a value of fly_anatomy.ontology is a consequence of FBbt having recently stopped to use OBO shorthands for some RO relations. I am not sure why such annotations were even present in CL in the first place (CL does not import FBbt), but in any case their removal is a healthy thing.

I am more concerned by things like this:

-property_value: depicted_by "http://upload.wikimedia.org/wikipedia/commons/d/d0/Canine-nose.jpg" xsd:anyURI
+property_value: depicted:by "http://upload.wikimedia.org/wikipedia/commons/d/d0/Canine-nose.jpg" xsd:anyURI

in some of the OBO artefacts. That depicted:by seems very wrong.

@ghost
Copy link
Author

ghost commented Oct 19, 2023

The disappearance of the oboInOwl#hasOBONamespace annotations with a value of fly_anatomy.ontology is a consequence of FBbt having recently stopped to use OBO shorthands for some RO relations. I am not sure why such annotations were even present in CL in the first place (CL does not import FBbt), but in any case their removal is a healthy thing.

@gouttegd, thank you for confirming.

I am more concerned by things like this:

-property_value: depicted_by "http://upload.wikimedia.org/wikipedia/commons/d/d0/Canine-nose.jpg" xsd:anyURI
+property_value: depicted:by "http://upload.wikimedia.org/wikipedia/commons/d/d0/Canine-nose.jpg" xsd:anyURI

in some of the OBO artefacts. That depicted:by seems very wrong.

@anitacaron, is this expected?

@anitacaron
Copy link
Contributor

unsure if this is related to obophenotype/uberon#3091. Is this expected?

They're unrelated, but it seems we don't have any control over the OBO format. Maybe it can be related to the change in CL that I removed the annotation declaration. It'll be fixed on the next Uberon release.

@aleixpuigb
Copy link
Collaborator

All the expected changes from PRs are reflected in the diff file.

Once the issues raised in the previous comments are solved, I will approve the PR.

@ghost
Copy link
Author

ghost commented Oct 19, 2023

All the expected changes from PRs are reflected in the diff file.

Once the issues raised in the previous comments are solved, I will approve the PR.

Thanks for reviewing.
It seems like the OBO formatting issue is benign (@anitacaron has approved) and will be resolved after a new Uberon release is available.

@ghost ghost merged commit f7936b8 into master Oct 19, 2023
2 checks passed
@ghost ghost deleted the release-2023-10-19 branch October 19, 2023 13:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants