-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add all-slpf-devices query-profile example to CDS04 #20
Comments
I think this raises an interesting question: if Example 1 (pub/sub): producer sends a Example 2 (pub/sub): producer sends a Example 3 (point-to-point): producer sends a |
I think we need to straighten out terminology between device, actuator, actuator profile. I think we allow a device to have multiple actuator profiles. I personally do not think of the functionality associated with a profile (eg slpf) as a 'different' device. It's not clear to me if it is a 'different' actuator. I do think we should distinguish between 'actuator' (the thing doing the function and the 'actuator profile' (metadata about the 'actuator'). I personally think actuators are functions of a device, not 'sub-devices' (ie they are not things in themselves). I pretty sure others think differently. I think we need to resolve this to be able to resolve the other issues. |
I agree this should be clarified, and then documented in the architecture. Is it worth raising the topic at the January TC meeting to tee it up for an in-depth conversation at the February L-SC? |
I'd start by assuming that device id is what goes in the message to/from field - URL or pub topic. Thus device = message sender / receiver = OpenC2 producer / consumer. So a message can be directed to a set of devices by topic, but not by actuator field. Example 2: producer sends a query features profiles request to oc2/cmd/all, with 'slpf' specified in the actuator field in the request. Because query features is an LS command, the response contains all profiles supported by every device that received the message, not just devices that support slpf. Example 3: (point to point). Response contains all profiles supported by the device. E.g., for commands defined by the LS the actuator field of the command is always ignored. A device supports all LS commands and all commands defined by its supported profiles, but when the actuator field is present it responds only to LS commands and the single specified profile. We wanted V1.0 to KISS, but in theory v2 could list more than one actuator and its supported specifiers in the actuator field. That's a non-compatible change so would have to wait for a new major version if we wanted it. |
in addition to issue #19, an example of a profile query to all slpf would help in understanding.
I think this example should be in the appendix (complete with topic, message, content) and referenced in section 2.2 as example of
topic: oc2/cmd/ap/[actuator_profile]
The text was updated successfully, but these errors were encountered: