Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove recommendation to use aget for JS object property access #15

Open
oakmac opened this issue Jul 5, 2017 · 4 comments
Open

remove recommendation to use aget for JS object property access #15

oakmac opened this issue Jul 5, 2017 · 4 comments
Assignees

Comments

@oakmac
Copy link
Owner

oakmac commented Jul 5, 2017

re: https://twitter.com/mfikes/status/882013594828800000

Should recommend using cljs-oops for JS object property access.

@oakmac oakmac self-assigned this Jul 5, 2017
@jiacai2050
Copy link

https://clojurescript.org/news/2017-07-14-checked-array-access

How is this issue going?
I think we need to remove this usage ASAP to avoid misguiding newbies.

@oakmac
Copy link
Owner Author

oakmac commented Jan 13, 2018 via email

@oakmac
Copy link
Owner Author

oakmac commented Jan 13, 2018

This is fixed now:

screen shot 2018-01-13 at 4 44 07 pm

@oakmac oakmac closed this as completed Jan 13, 2018
@jiacai2050
Copy link

jiacai2050 commented Jan 16, 2018

Great, I think we can also add goog.object/get, goog.object/set, goog.object/getValueByKeys, and put cljs-oops in External Library section

@oakmac oakmac reopened this Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants