Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji with skin tone is not recognized as emoji #300

Closed
1 of 4 tasks
azzamsa opened this issue Jun 21, 2024 · 3 comments · May be fixed by #280
Closed
1 of 4 tasks

Emoji with skin tone is not recognized as emoji #300

azzamsa opened this issue Jun 21, 2024 · 3 comments · May be fixed by #280
Labels
bug Something isn't working

Comments

@azzamsa
Copy link

azzamsa commented Jun 21, 2024

Description

Emoji with skin tone is not recognized as emoji

Problem Explanation

If you copy a regular emoji such as 🙏, it is recognized as emoji.
But, it doesn't when you choose the same emoji with other skin tone such 🙏🏻

image

Expected Behavior

It should recognize both of them as emoji and display with the same size.

Reprodution

Steps To Reproduce

Steps to reproduce, if applicable:

  1. Copy https://emojipedia.org/folded-hands
  2. Copy https://emojipedia.org/folded-hands-light-skin-tone
  3. See the difference

Details

It happens with any application?

  • Yes, it applies to any application.
  • [-] No. Only with the following applications:
    • VSCode
  • [- ] It works with the following applications that I have tried:
    • Fill in a list with any application that applies

It happens only on one computer?

  • [X ] I don't know.
  • No. I have tried it on more than one computer.

It happens only with some specific gnome configuration?

  • [ X] I don't think that the configuration matters.
  • Yes. Only if the following config is set up:
    • Fill in a list with any configuration tha applies.

It happens only with some specific extension installed?

  • [ X] I don't think that the installed extensions affect the bug/behavior.
  • Yes. Only if the following gnome extension is installed:
    • Fill in a list with any extension tha applies.
    • Fill in also any detail about the extensions that applies.
@azzamsa azzamsa added the bug Something isn't working label Jun 21, 2024
@azzamsa
Copy link
Author

azzamsa commented Jun 21, 2024

We need to handle the additional byte for the skin tone.
Related issue: hrsh7th/cmp-emoji#11

@boerdereinar boerdereinar mentioned this issue Jun 21, 2024
9 tasks
@boerdereinar
Copy link

Fixed in #280 by just marking any single grapheme cluster as an emoji item.
Screenshot from 2024-06-21 20-06-38

@azzamsa
Copy link
Author

azzamsa commented Jun 21, 2024

Amazing work! Thank you. 🍜

@azzamsa azzamsa closed this as completed Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants