ovirt-doc team can no longer merge PRs without outside reviewer

[apinnick]

The Ovirt-doc team used to be able to merge PRs without an outside reviewer. This is necessary in order forthe writers to do quick fixes such as typos, updating RN, or to publish urgent documents. Ovirt-doc used to have this ability. However, the feature seems to have been removed recently.

[ghost]

@sandrobonazzola I don't have admin rights, could you please take a look?

[sandrobonazzola]

checking

[sandrobonazzola]

According to GitHub config the doc team should be able to bypass the review requirements on the PRs:

@apinnick can you please provide an example of PR where the doc team can't merge?

[apinnick]

I don't mean that the doc team can't merge a PR. I mean that the person who created the PR can't merge it. I will try to create a PR to show you.

[sandrobonazzola]

You should have something like:

[sandrobonazzola]

Just check the checkbox and you should be able to merge your own PRs bypassing the review requriement.

[apinnick]

I know that is how it is supposed to work. I have used it in the past. Recently I could not do that. I'm checking it now with a PR.

[apinnick]

This is what appears. There is no option to merge without waiting for requirements to be met. PR

[ghost]

@sandrobonazzola it seems this one is stuck because a status check is misconfigured. However, GitHub had some issues this morning, it may be that that's the reason why it doesn't work.

[apinnick]

@janosdebugs This is not a one-off problem. I noticed it a couple weeks ago when I had a PR for the REST API.

[apinnick]

I noticed that Eli's PR was also stuck in this state. I submitted a 'test' review and it allowed me to merge. So the end result is the same -- no reviewer, no merge.

[sandrobonazzola]

I'l try adding doc team members one by one instead of adding the group.

[emarcusRH]

this behavior seems to have popped up recently - sometime around the beginning of September. All of my PRs in the last 2 weeks have been behaving like this - no option to merge without an additional reviewer - and even approval by authorized Dev reviewers, like Yedidyah, did not open the PR for merging.

[sandrobonazzola]

check now

[apinnick]

check now

I see no changes in my PR. I'll try pushing a change to rerun the checks.

[sandrobonazzola]

@michalskrivanek any change done in global config over the past few weeks?

[michalskrivanek]

no, nothing I'm aware of

[michalskrivanek]

i do not see a history, but currently the project is set up so that it requires one review

[apinnick]

i do not see a history, but currently the project is set up so that it requires one review

The ovirt-doc team is supposed to be an exception, so that we can do quick fixes that do not require review.

[apinnick]

check now

No change. My PR still requires a reviewer.

[ghost]

@apinnick I just checked and this seems to be a change on GitHub's side and we can't really do anything about it apart from removing the review requirements completely.

[apinnick]

@apinnick I just checked and this seems to be a change on GitHub's side and we can't really do anything about it apart from removing the review requirements completely.

Unfortunate..... Thanks for checking.

[emarcusRH]

It seems odd though, that approval from Yedidya on one of my ovirt PRs was not sufficient to allow merging?

[ghost]

Folks, if you need help bypassing review requirements feel free to ping me on chat, I'll happily add a blanket review. :D

[michalskrivanek]

I've got similar report from other repos, there as no config change and AFAICT from settings these people (https://github.com/orgs/oVirt/teams/ovirt-documentation/members) can merge without reviews.
Looks like yet another github outage/bug...