Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner proposal for 4.5.0 GA #2797

Closed
sandrobonazzola opened this issue Mar 21, 2022 · 11 comments · Fixed by #2843
Closed

Banner proposal for 4.5.0 GA #2797

sandrobonazzola opened this issue Mar 21, 2022 · 11 comments · Fixed by #2843
Assignees
Labels
in progress upstream PR or issue that applies only to upstream
Milestone

Comments

@sandrobonazzola
Copy link
Member

Description of the problem

Type of problem?

Content issue

Proposing banners for 4.5.0 GA
Website:
Site Banner

Twitter:
Twitter Banner

Reddit:
Reddit Banner

Facebook:
Facebook Banner

Linkedin:
LinkedIn Banner

@sandrobonazzola sandrobonazzola self-assigned this Mar 21, 2022
@sandrobonazzola sandrobonazzola added the upstream PR or issue that applies only to upstream label Mar 21, 2022
@sandrobonazzola sandrobonazzola added this to the ovirt-4.5.0 milestone Mar 21, 2022
@sandrobonazzola
Copy link
Member Author

Sources:

Facebook Banner
LinkedIn Banner
Reddit Banner
Site Banner
Twitter Banner

@sandrobonazzola
Copy link
Member Author

@oVirt/developers any comment?

@erav
Copy link
Member

erav commented Mar 31, 2022

I vote for the one with the 'download now' text

@michalskrivanek
Copy link
Member

our download's always a little more complicated than for many other projects, i'd be happy with just "4.5 has been released!":)

@nirs
Copy link
Member

nirs commented Mar 31, 2022

If I understand correctly, this PR propose multiple banners for the ovirt side, twitter, facebook, reddit and linked in.

The banners use different font families and weights (e.g "4.5" is sometimes bold and sometimes not). Is this intended?

@barpavel
Copy link
Member

Even if the Download process is a little complicated, what's the purpose of advertising the release if the user needs to invest efforts in searching where he/she can actually get it?
IMHO at least reaching the Download page should be simple, otherwise users will need to work hard to both find it and then download it :)
I think having a Download link on the Website is nice.
And regarding Nir's comment - yes, also the second line in Twitter image is much wider that the 1st line, while on other 3 images both lines are more or less the same width.

@sandrobonazzola
Copy link
Member Author

Thanks for the feedback! I'll try to uniform font sizing and styling. About the download button I also got feedback that cyrcles needs better alignment. I agree with @barpavel , pointing to somewhere with instructions on how to download make sense here.

@sandrobonazzola
Copy link
Member Author

Second round: didn't touch the Reddit banner.

Site:
Site Banner

Facebook:
Facebook Banner

Linkedin:
LinkedIn Banner

Twitter:
Twitter Banner

Sources:
Facebook Banner
LinkedIn Banner
Site Banner
Twitter Banner

@nirs
Copy link
Member

nirs commented Mar 31, 2022

Looks good now 👍

@barpavel
Copy link
Member

barpavel commented Apr 1, 2022

LGTM :)

@erav
Copy link
Member

erav commented Apr 3, 2022

in the image before last the 'download now!' is larger than the blue button. otherwise LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in progress upstream PR or issue that applies only to upstream
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants