Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document how custom feature stores are used at query time #215

Open
fiorinin opened this issue Feb 22, 2019 · 4 comments
Open

Document how custom feature stores are used at query time #215

fiorinin opened this issue Feb 22, 2019 · 4 comments

Comments

@fiorinin
Copy link

Hi,

It looks like reranking won't work if we use non-default stores. That is, after I uploaded my model, I can see it at this address:
http://localhost:9203/_ltr/store_name/_model/model_name

Similarly, because it's in a specific store, this address doesn't return anything (per the documentation):
http://localhost:9203/_ltr/_model/

But this one does:
http://localhost:9203/_ltr/store_name/_model/

Then when I need to rescore using

{
    "query": {
        "sltr": {
                "params": {
                    "keywords": query_string
                },
                "model": "model_name",
            }
    }
}

The plugin returns it can't find the model. I tried concatenating the store in the name, or using the ID, vainly. Is there a way, currently, to make this work? If not, could you point me where I should look in the plugin to fix it?

Thanks a lot!

@nomoa
Copy link
Collaborator

nomoa commented Feb 22, 2019

Sure, you simply have to provide the store name in the store param:

{
    "query": {
        "sltr": {
                "params": {
                    "keywords": query_string
                },
                "model": "model_name",
                "store": "store_name"
            }
    }
}

I haven't tested so feel free to reopen if this does not work as expected.

@nomoa nomoa closed this as completed Feb 22, 2019
@ebernhardson
Copy link
Collaborator

Sounds like, at minimum, we might need a documentation patch? Will need to review the docs to double check.

@fiorinin
Copy link
Author

Thanks a lot! I’ll try that and let you know if there’s a problem. Yes, during my discovery of the plugin - for which I’m very thankful BTW - I previously noticed aspects that weren’t covered in the documentation. I could find the answers by browsing the code usually, but I got stuck on this one. I’m pretty sure I’m missing so many things because the documentation doesn’t seem to reflect how powerful the plugin is.

Thanks a lot again for your answer!

@nomoa
Copy link
Collaborator

nomoa commented Feb 25, 2019

Thanks, and sorry to have closed this issue too quickly, I agree with @ebernhardson a doc update to mention how to use feature stores is indeed the least we should do.

@nomoa nomoa reopened this Feb 25, 2019
@nomoa nomoa changed the title Reranking with a model name does not work if we use custom stores Document how custom feature stores are used at query time Feb 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants