Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updatable settings for cache #139

Open
ebernhardson opened this issue Feb 21, 2018 · 1 comment
Open

Use updatable settings for cache #139

ebernhardson opened this issue Feb 21, 2018 · 1 comment

Comments

@ebernhardson
Copy link
Collaborator

Currently attempting to change the size of the model cache from the cluster settings api results in an error. I don't see any reason this needs to be static. The easy part of this is adding a call to ClusterService::addSettingsUpdateConsumer on init to receive the updates, slightly harder will be adjusting the cache to handle resizing.

PUT /_cluster/settings
{"transient": {"ltr.caches.max_mem": "50mb"}}
{"error":{"root_cause":[{"type":"illegal_argument_exception","reason":"transient setting [ltr.caches.max_mem], not dynamically updateable"}],"type":"illegal_argument_exception","reason":"transient setting [ltr.caches.max_mem], not dynamically updateable"},"status":400}
@jettro
Copy link
Collaborator

jettro commented Apr 25, 2019

I'd like to pick this one up. Already made some changes to make the consumer and verified I get a callback when changing the property. SO next step is to decide what to do. Will come up with some ideas, but of course open to suggestions from everybody what they feel should happen when changing one of the properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants