Add support for zstd compression #695
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
l7ssha
reviewed
Oct 6, 2024
Comment on lines
+470
to
+471
| // See https://github.com/instantiations/es_compression/issues/52 for why the isNotEmpty check is needed. | ||
| Stream<dynamic> decompressZStdTransport(Stream<List<int>> raw) => raw.transform(zstd.decoder).where((message) => message.isNotEmpty); |
There was a problem hiding this comment.
is isNotEmpty still needed? instantiations/es_compression#52 (comment)
l7ssha
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for zstd-stream transport compression.
Drafted for now so we can determine whether adding a dependency on another package for this is worth it, especially as it is an unofficial third-party package based on FFI, and not portable.
Type of change
Checklist:
dart analyzeormake analyzeand fixed all issuesdart format --set-exit-if-changed -l 160 ./libormake formatand fixed all issues