Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu button for User Settings - revisit #143

Open
lhenze opened this issue Dec 6, 2021 · 0 comments
Open

Menu button for User Settings - revisit #143

lhenze opened this issue Dec 6, 2021 · 0 comments
Labels
a11y - significant Accessibility issues -- Must be fixed

Comments

@lhenze
Copy link
Member

lhenze commented Dec 6, 2021

From a11y review -

When a user is logged in, the menu button for User Settings is not constructed in a way that maps to the expected pattern. There are two elements in the element - a "link" to the actual page for the User Settings, and a menu button that has the same options that exist on the User Settings page. The only option that is different is the "Log Out". Consider if the menu button is necessary.

Also, adding an aria-label to the link will provide more information about the destination for the screen reader user. For example:

<a class="ui button" href="/account/settings/profile/" aria-label="User Settings and Profile"> <i class="user icon"></i> [email protected] </a>

@lhenze lhenze added the a11y - significant Accessibility issues -- Must be fixed label Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y - significant Accessibility issues -- Must be fixed
Projects
None yet
Development

No branches or pull requests

1 participant