Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hexdump returns error even when successful #62

Open
gregokent opened this issue Apr 18, 2021 · 1 comment
Open

Hexdump returns error even when successful #62

gregokent opened this issue Apr 18, 2021 · 1 comment

Comments

@gregokent
Copy link

If the hexdump command succeeds, it'll still end up returning an error as the success case will end up falling through to filesystem_error1: where it gets remapped to SJA1105_ERR_FILESYSTEM before returning.
https://github.com/openil/sja1105-tool/blob/085d42c72c4e9508aa7bc9bfbbb5fe41082fcdec/src/tool/staging-area.c#L122-L132

As a result, the sja1105-init startup script will always find the config to be invalid and create it anew:
https://github.com/openil/sja1105-tool/blob/085d42c72c4e9508aa7bc9bfbbb5fe41082fcdec/etc/sja1105-init#L25-L28
@vladimiroltean
Copy link
Contributor

Hi,
It looks like you found a bug. Would you mind sending a pull request with a patch?
Thanks,
Vladimir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gregokent @vladimiroltean