Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: module_config argument to mrc.Builder.load_module should accept a default argument #413

Open
2 tasks done
dagardner-nv opened this issue Nov 7, 2023 · 0 comments
Open
2 tasks done

[BUG]: module_config argument to mrc.Builder.load_module should accept a default argument #413

dagardner-nv opened this issue Nov 7, 2023 · 0 comments
Assignees
@drobison00
Labels
bug Something isn't working

Comments

@dagardner-nv
Copy link
Contributor

Version

23.11

Which installation method(s) does this occur on?

Source

Describe the bug.

We should be able to call load_module without the module_config argument in the case when the config is empty.

This call

builder.load_module("my_compound_op_module", "my_module_namespace", "op_module")

should be equivalent to:

builder.load_module("my_compound_op_module", "my_module_namespace", "op_module", {})

Minimum reproducible example

No response

Relevant log output

No response

Full env printout

No response

Other/Misc.

No response

Code of Conduct

  • I agree to follow MRC's Code of Conduct
  • I have searched the open bugs and have found no duplicates for this bug report
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drobison00 drobison00

Labels
bug Something isn't working
Projects
Morpheus Boards
Status: Todo
Milestone
No milestone
Development

No branches or pull requests
2 participants
@drobison00 @dagardner-nv