Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legate driver tests: "no ucx" is not always the default #873

Open
manopapad opened this issue Oct 19, 2023 · 0 comments
Open

Legate driver tests: "no ucx" is not always the default #873

manopapad opened this issue Oct 19, 2023 · 0 comments

Comments

@manopapad
Copy link
Contributor

Paraphrasing from a description of the issue by @bryevdv:

Most legate driver tests were originally developed in an env where there was never "ucx" present, so install_info.networks is not actually tightly controlled in every test, just due to oversight. I.e. "ucx" is explicitly added in tests intended to be "with ucx" but it's not explicitly removed in all other tests that just assume "without ucx" is the defatult state.

We should actually go through and remove the assumption that "no ucx" is always the "default".

See https://github.com/nv-legate/legate.core/actions/runs/6571421549/job/17850858678 for a case where this backfired, when ucx was added to the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant