New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky `ModuleArchiveContainer` test #3873

Open

kokrui opened this issue Nov 25, 2024 · 0 comments

Labels

bug

Member

kokrui commented Nov 25, 2024

This test is flaky

nusmods/website/src/views/modules/ModuleArchiveContainer.test.tsx

Lines 82 to 86 in 3c2418f

    
           test('should show 404 page when the course code does not exist', async () => { 
        
             mockAxiosRequest.mockRejectedValue(notFoundError); 
        
             make('/archive/CS1234/2017-2018'); 
        
             expect(await screen.findByText(/course CS1234 not found/)).toBeInTheDocument(); 
        
           });

I believe it fails because the text is split up into multiple DOM elements / split up (e.g., if it renders like this I believe the test fails)

We should fix this!

kokrui added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment