-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a docs favicon #469
Comments
Hey @rl-83 perfect. I don't have edit access to the figma in edit. Can you export it for me in .svg (color and black and white) ? thanks |
@rvveber any idea we can make that easily overidable at build time like you did for the logo ? |
@virgile-dev I will take a look to find an elegant solution when i have time. Probably next week. The problem is, that favicons, just like tsx modules, will be compiled into optimized files that can be served to the browser. (As it should be) this happens before/when the Image is created. When an admin wants to host the image he only has access to the finished image. In the scope of favicons, it's possible, we can instruct the node application to look for the file dynamically. |
So what an admin needs to do, to get his overrides at built-time
|
Ideally, it'd be great that you don't have to this in a fork using config files and env variables |
Bug Report
Problematic behavior
As a user I want to identify easily the browser tabs that are
docs
.Right now Docs has La Marianne, which is not generic nor indicates clearly which website it is.
Expected behavior/code
I'd like to have a Docs favicon.
It should be easily overidable so that admin sys deploying docs can easily add they own favicon (the nav bar logo should be overidabel as well)
Additional context / Screenshots
The Favicon could be derived from this:
@rl-83 could you propose a design for the favicon please ?
The text was updated successfully, but these errors were encountered: