Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pipeline examples/multi_udf/numa-pl.yaml in main branch does not conform to the pipeline CRD #396

Open
gopaljayanthi opened this issue Jun 17, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@gopaljayanthi
Copy link

gopaljayanthi commented Jun 17, 2024

Describe the bug
pipeline examples/multi_udf/numa-pl.yaml in main branch has .spec.edges[3].conditions is wrong, it has keyIn field where as the CRD requires tags field
To Reproduce

  1. git clone https://github.com/numaproj/numalogic.git
  2. cd numalogic
  3. kubectl apply -f examples/multi_udf/numa-pl.yaml

Expected behavior
pipeline should be created

Screenshots
k apply -f https://raw.githubusercontent.com/numaproj/numalogic/main/examples/multi_udf/numa-pl.yaml
deployment.apps/mlflow-sqlite created
service/mlflow-service created
Error from server (BadRequest): error when creating "https://raw.githubusercontent.com/numaproj/numalogic/main/examples/multi_udf/numa-pl.yaml": Pipeline in version "v1alpha1" cannot be handled as a Pipeline: strict decoding error: unknown field "spec.edges[3].conditions.keyIn", unknown field "spec.edges[4].conditions.keyIn"

Environment (please complete the following information):

  • Kubernetes:v1.29.2
  • Numaflow: quay.io/numaproj/numaflow:v1.2.1
  • Numalogic: [e.g. v0.2.0]
  • Numaflow-python: [e.g. v0.1.1]

Additional context
using docker-dektop on windows 10 with ubuntu 18.04 vm as the kubernetes


Message from the maintainers:

Impacted by this bug? Give it a 👍. We often sort issues this way to know what to prioritize.

@gopaljayanthi gopaljayanthi added the bug Something isn't working label Jun 17, 2024
@ab93
Copy link
Member

ab93 commented Jun 18, 2024

Hi @gopaljayanthi thanks for bringing this on our attention. Will test and update it soon.

@naveenkumarsp
Copy link

I am facing diffrent issue when i tried applying numa-pl.yaml.

Error from server (BadRequest): error when creating "https://raw.githubusercontent.com/numaproj/numalogic/main/examples/multi_udf/numa-pl.yaml": admission webhook "webh
ook.numaflow.numaproj.io" denied the request: invalid vertex "train", UDF must have to and from edges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants