-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Definition of Fresnel coefficients #702
Comments
Here is what the above would look like: develop...philippwindischhofer:NuRadioMC:phwindis_fresnel |
Hi Phillip, I had a similar discussion with myself several years ago: nu-radio/NuRadioReco#97 but I couldn't come to a conclusion because the current implementation agrees with measured data. It seems that your solution (inverting the sign of r_p + adding the complex conjugate) will leave the phase shift for TIR invariant for the p-polarization? Then it will be compatible with the ARIANNA DnR data. |
Hi Christian! Thanks for digging out that old discussion! I had searched around, but couldn't find anything---I had totally overlooked that archived repository. I'll read up on the discussion there.
Correct, for cases (like TIR) where Cheers, |
Note that the sign of the Fresnel Coefficients is (oddly) a convention. See e.g: https://ieeexplore.ieee.org/document/9184440 Though it's entirely possible you already know this and I'm missing the point of confusion. |
Hi Cosmin, if I understand correctly, NuRadioMC uses what your reference calls the "antiparallel |
@cg-laser I just wanted to check back briefly to see if you have had any chance to think about this? How do you think we should proceed? |
this looks very good! Thanks for the comparison. |
Yes, the Green's function comes from MEEP! |
Hi all,
(First of all, I have only recently started using NuRadioMC and my question below might simply be a consequence of me misunderstanding the code or its coordinate system. Apologies if that is the case.)
My question is: does anybody happen to have a reference for where the Fresnel coefficients
r_p
andr_s
(defined here) have been taken from? I am wondering particularly about the overall sign ofr_p
(where e.g. Jackson differs from NuRadioMC), and its phase shift in the case of total internal reflection. I attach more information below.Sign of
r_p
: Looking at Eq. 7.60 in Jackson (page 220 here) and converting to the same notation used in NuRadioMC, there seems to be an overall sign difference relative to NuRadioMC. The same is true for the definition given on Wikipedia. If anybody remembers the original reference that was used in the code, I'd love to take a look at it to understand this difference.Phase shift for total internal reflection: Again taking Jackson's derivation for concreteness, he uses the "negative frequency"
$\exp(-i*\omega*t)$
convention (e.g. Eq. 7.49 on page 217 here). In NuRadioMC, the Fresnel coefficients are applied as multiplicative factors to the Fourier spectra of the signals. The spectra are calculated throughnp.rfft
, which returns the "positive-frequency" components (see documentation here and sign convention here). To apply the correct phase shift, shouldn't one then use the complex conjugate of the Fresnel coefficients? This only matters in cases with total internal reflection, of course. Again, whether or not complex conjugation should be applied is easy to establish if we can look up the sign conventions used in the original reference.Please let me know what you think! Tagging @sjoerd-bouma and @cg-laser, who touched this code before. I'm probably missing other people who have worked on this before.
Cheers,
Philipp
The text was updated successfully, but these errors were encountered: