Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Too many CoREAS readers #671

Open
anelles opened this issue Apr 10, 2024 · 2 comments
Open

Too many CoREAS readers #671

anelles opened this issue Apr 10, 2024 · 2 comments

Comments

@anelles
Copy link
Collaborator

anelles commented Apr 10, 2024

This is just to keep track of the issue and collect the discussion of how to move forward.

@lpyras, @MijnheerD, @twybo have been working on different CoREAS readers recently and in particular with the interpolation function in https://github.com/nu-radio/cr-pulse-interpolator there seem to be a issue in reconciling where the modularity is kept.

Currently every reader also contains part of the analysis approach (i.e. reading just one station, reading random stations, interpolating to a given detector) and the question is whether we could modularize further to avoid duplication of the general reading functionality that parses the CoREAS files and generating the interpolator object (if so desired).

@anelles
Copy link
Collaborator Author

anelles commented Apr 10, 2024

@cg-laser this seems like a discussion that once needs to be had during a developers call.

@lpyras
Copy link
Collaborator

lpyras commented May 31, 2024

This will be addressed in PR #685

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants