Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ray tracing solution appears twice #239

Open
cg-laser opened this issue Sep 9, 2020 · 0 comments
Open

Ray tracing solution appears twice #239

cg-laser opened this issue Sep 9, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@cg-laser
Copy link
Collaborator

cg-laser commented Sep 9, 2020

In rare cases both the direct and reflected solution are returned for almost the same ray. Receive angles differ by a fraction of a degree

In [13]: sim_station.get_electric_fields()[0][efp.zenith]/units.deg
Out[13]: 37.990554573137445

In [14]: sim_station.get_electric_fields()[1][efp.zenith]/units.deg
Out[14]: 37.98455113752616

In [9]: sim_station.get_electric_fields()[0][efp.ray_path_type]
Out[9]: 'direct'

In [10]: sim_station.get_electric_fields()[1][efp.ray_path_type]
Out[10]: 'reflected'

This must be a bug as the direct solution should originate from below.

@anelles anelles added the bug Something isn't working label Jan 5, 2021
cg-laser pushed a commit that referenced this issue Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants