Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Number of ray tracing solutions is not stable as a function of root finding tolerance parameter #1

Open
clark2668 opened this issue Sep 17, 2018 · 4 comments
Labels
bug Something isn't working

Comments

@clark2668
Copy link
Collaborator

clark2668 commented Sep 17, 2018

The number of solutions for the ray tracing problem is not stable as a function of the root finding tolerance parameter tol in analyticraytracing.py.

For example, the following code:

x1 = np.array([478., 0., -149.])
x2 = np.array([1000., 0., -90.]) # direct ray solution
ice = medium.ARAsim_southpole()
r = ray.ray_tracing(x1,x2,ice)
r.find_solutions()

Returns only one solution when tol=1e-4 but has two solutions when tol=1e-5.

@anelles anelles added the bug Something isn't working label Mar 1, 2019
@anelles
Copy link
Collaborator

anelles commented May 23, 2019

@cg-laser does your improvement in pull request #80 also address this issue?

@cg-laser
Copy link
Collaborator

Maybe, I can check. The objective function should look better now.

@cg-laser
Copy link
Collaborator

why is @clark2668 comment not visible on github?

@clark2668
Copy link
Collaborator Author

Sorry @cg-laser , I deleted the comment. I realized I misunderstood the question before I answered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants