Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename XUnitFormatter to JUnitFormatter #179

Open
BennieCopeland opened this issue Mar 29, 2017 · 5 comments
Open

Rename XUnitFormatter to JUnitFormatter #179

BennieCopeland opened this issue Mar 29, 2017 · 5 comments

Comments

@BennieCopeland
Copy link
Contributor

So, apparently there is the xUnit format which is VERY similar to the JUnit format. Then there is the XUnit format used by the XUnit project with its own format. Guess which one works in TFS.

@GiuseppePiscopo
Copy link
Collaborator

Hi there,

could you please clarify a little more? I'm not getting it, my bad, as I don't use XUnit formatting a lot. To which format are you referring to when you say the xUnit format similar to...?

@BennieCopeland
Copy link
Contributor Author

So I just learned this while trying to get my tests into TFS. There is xUnit which is a collective name for test frameworks patterned after Smalltalk's SUnit. The xUnit test result format came about from JUnit, and other xUnit style tests frameworks copied it.

Then there is XUnit.Net, which is another xUnit style test framework, but they have their own incompatible format. The TFS build step for importing a test results xml file supports JUnit, NUnit, VSTest, and XUnit (XUnit.Net). With this formatter named with XUnit, there was some confusion on my part on why TFS was failing to import my test results. Once I switched TFS to JUnit, it imported them fine.

@GiuseppePiscopo
Copy link
Collaborator

Oh, ok, now I see it. So our current XUnitFormatter is producing output compatible with the general xUnit framework, which in TFS is dubbed as JUnit.

Then TFS calls XUnit the format specific to xUnit.net, and this confuses things when selecting import format.

If this is the case, I'd say that we should put a note on this when we add docs on formatters. /cc @amirrajan

@amirrajan
Copy link
Collaborator

Or just create a new class called XUnitFormatterForTFS that just inherits? (With docs)

@BennieCopeland
Copy link
Contributor Author

BennieCopeland commented Apr 1, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants