Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make validation more simple and reuse config in components #2994

Open
End-rey opened this issue Oct 31, 2024 · 0 comments
Open

Make validation more simple and reuse config in components #2994

End-rey opened this issue Oct 31, 2024 · 0 comments
Labels
config Configuration format update or breaking change enhancement Improving existing functionality I3 Minimal impact neofs-ir Inner Ring node application issues neofs-storage Storage node application issues S3 Minimally significant U3 Regular
Milestone

Comments

@End-rey
Copy link
Contributor

End-rey commented Oct 31, 2024

Is your feature request related to a problem? Please describe.

I'm always frustrated when additional proprietary logic is used for validation, when existing solutions can be used. It is also unpleasant when the config structure is used only for validation, although it can be used in various components.

Describe the solution you'd like

Make validation through viper.UnmarshalExact and reuse the config struct in the components.

Describe alternatives you've considered

Keeping as is, but with a lot of code and duplicate structures.

Additional context

Refs #2981.
First, you need to change the config so that you can perform validation simply: #2993.

@End-rey End-rey added enhancement Improving existing functionality neofs-ir Inner Ring node application issues neofs-storage Storage node application issues blocked Can't be done because of something U3 Regular config Configuration format update or breaking change S3 Minimally significant I3 Minimal impact labels Oct 31, 2024
@roman-khimov roman-khimov removed the blocked Can't be done because of something label Dec 3, 2024
@roman-khimov roman-khimov added this to the v0.45.0 milestone Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
config Configuration format update or breaking change enhancement Improving existing functionality I3 Minimal impact neofs-ir Inner Ring node application issues neofs-storage Storage node application issues S3 Minimally significant U3 Regular
Projects
None yet
Development

No branches or pull requests

2 participants