Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actualize wallets #267

Open
notimetoname opened this issue Jun 19, 2023 · 3 comments
Open

Actualize wallets #267

notimetoname opened this issue Jun 19, 2023 · 3 comments
Labels
discussion Open discussion of some problem documentation Improvements or additions to documentation help wanted Extra attention is needed I4 No visible changes S3 Minimally significant U4 Nothing urgent

Comments

@notimetoname
Copy link
Contributor

As I understand we have some copypasted accounts for years (

{
"address": "NVTiAjNgagDkTr5HTzDmQP9kPwPHN5BgVq",
"key": "6PYM8VdX2BSm7BSXKzV4Fz6S3R9cDLLWNrD9nMjxW352jEv3fsC8N3wNLY",
"label": "",
"contract": {
"script": "EwwhAhA6f33QFlWFl/eWDSfFFqQ5T9loueZRVetLAT5AQEBuDCECp7xV/oaE4BGXaNEEujB5W9zIZhnoZK3SYVZyPtGFzWIMIQKzYiv0AXvf4xfFiu1fTHU/IGt9uJYEb6fXdLvEv3+NwgwhA9kMB99j5pDOd5EuEKtRrMlEtmhgI3tgjE+PgwnnHuaZFEGe0Nw6",
"parameters": [
{
"name": "parameter0",
"type": "Signature"
},
{
"name": "parameter1",
"type": "Signature"
},
{
"name": "parameter2",
"type": "Signature"
}
],
"deployed": false
},
"lock": false,
"extra":null,
"isDefault": false
},
? multi-sig? what? @roman-khimov, @AnnaShaleva).

Also, some of them have labels while some do not. I would expect a perfect repo with wallets to be fully labeled. Wallet naming also bothers me (node-wallet.json (what wallet? neo-go? neofs-node?)/wallet.json).

@notimetoname notimetoname added documentation Improvements or additions to documentation help wanted Extra attention is needed discussion Open discussion of some problem labels Jun 19, 2023
@AnnaShaleva
Copy link
Member

? multi-sig? what?

Yes, it's multisignature account 3/4:

NEO-GO-VM > loadbase64 EwwhAhA6f33QFlWFl/eWDSfFFqQ5T9loueZRVetLAT5AQEBuDCECp7xV/oaE4BGXaNEEujB5W9zIZhnoZK3SYVZyPtGFzWIMIQKzYiv0AXvf4xfFiu1fTHU/IGt9uJYEb6fXdLvEv3+NwgwhA9kMB99j5pDOd5EuEKtRrMlEtmhgI3tgjE+PgwnnHuaZFEGe0Nw6
READY: loaded 147 instructions
NEO-GO-VM 0 > ops
INDEX    OPCODE       PARAMETER
0        PUSH3            <<
1        PUSHDATA1    02103a7f7dd016558597f7960d27c516a4394fd968b9e65155eb4b013e4040406e
36       PUSHDATA1    02a7bc55fe8684e0119768d104ba30795bdcc86619e864add26156723ed185cd62
71       PUSHDATA1    02b3622bf4017bdfe317c58aed5f4c753f206b7db896046fa7d774bbc4bf7f8dc2
106      PUSHDATA1    03d90c07df63e690ce77912e10ab51acc944b66860237b608c4f8f8309e71ee699
141      PUSH4        
142      SYSCALL      System.Crypto.CheckMultisig (9ed0dc3a)

@AnnaShaleva
Copy link
Member

Generally it's a good practice to add label if there are several accounts into wallet. And even if it's just a sigle account, it's a good idea to properly label it, so +1 from my side for this issue.

@carpawell
Copy link
Member

Yes, it's multisignature account 3/4:

Useless parts should be dropped then, I guess.

@roman-khimov roman-khimov added U4 Nothing urgent S3 Minimally significant I4 No visible changes labels Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Open discussion of some problem documentation Improvements or additions to documentation help wanted Extra attention is needed I4 No visible changes S3 Minimally significant U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

4 participants