Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it clear that EXPIRATION_EPOCH is the last "available" epoch for all entities #253

Open
carpawell opened this issue Dec 20, 2022 · 5 comments
Labels
documentation Improvements or additions to documentation I3 Minimal impact S4 Routine U4 Nothing urgent
Milestone

Comments

@carpawell
Copy link
Member

Check all the descriptions/comments. Related to regular and irregular objects, tokens.

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Dec 20, 2022

I suggest to either

  1. exclude session and bearer tokens since it's a nonsense to use well-known naming with a change of meaning
  2. stop reflecting JWT notations in NeoFS tokens

@carpawell
Copy link
Member Author

If i have to choose, i would do 2.. But also, as @realloc says JWT is about seconds while epoch is about minutes and even hours. JWT allows inevitable time delta which means "somewhen near that second expiration should happen" so it is not that strict in the real world.

/cc @fyrchik.

@realloc
Copy link

realloc commented Dec 20, 2022

As @carpawell has already mentioned, we live in another time model and technically do the same thing as JWT does with X seconds splay on token expiration checks.

@cthulhu-rider
Copy link
Contributor

cthulhu-rider commented Dec 20, 2022

IMO in most cases user wants to set expiration epoch - the timestamp when its product becomes unavailable. If he actually wants to set last available claim, he just sets next epoch as an exp claim. I don't see any reason to go off specification (if you fix the desire to follow it).

@realloc
Copy link

realloc commented Dec 21, 2022

Let's stick to how we treat expiration epoch for objects.

@roman-khimov roman-khimov added U4 Nothing urgent S4 Routine I3 Minimal impact and removed U3 Regular labels Dec 20, 2023
@roman-khimov roman-khimov added this to the v2.17.0 milestone Dec 26, 2024
roman-khimov added a commit that referenced this issue Dec 26, 2024
This is the way it is now, just improving the documentation.

Signed-off-by: Roman Khimov <[email protected]>
roman-khimov added a commit that referenced this issue Dec 26, 2024
This is the way it is now, just improving the documentation.

Signed-off-by: Roman Khimov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation I3 Minimal impact S4 Routine U4 Nothing urgent
Projects
None yet
Development

No branches or pull requests

4 participants