From 91814b3fe37d64adafa8b3d943f775f8fe57ef90 Mon Sep 17 00:00:00 2001 From: Julian Waller Date: Fri, 29 Sep 2023 15:49:48 +0100 Subject: [PATCH] fix: remove unused casparcg useScheduling option --- .../src/generated/casparCG.ts | 4 ---- .../examples/testChangeTimelineQuickly.ts | 1 - .../casparCG/$schemas/options.json | 6 ------ .../casparCG/__tests__/casparcg.spec.ts | 20 ------------------- 4 files changed, 31 deletions(-) diff --git a/packages/timeline-state-resolver-types/src/generated/casparCG.ts b/packages/timeline-state-resolver-types/src/generated/casparCG.ts index 117c269418..dd78c6f314 100644 --- a/packages/timeline-state-resolver-types/src/generated/casparCG.ts +++ b/packages/timeline-state-resolver-types/src/generated/casparCG.ts @@ -25,10 +25,6 @@ export interface CasparCGOptions { * Interval (ms) for retrying to load media that previously failed. (-1 disables, 0 uses the default interval) */ retryInterval?: number - /** - * whether to use the CasparCG-SCHEDULE command to run future commands, or the internal (backwards-compatible) command queue - */ - useScheduling?: boolean } export interface MappingCasparCGLayer { diff --git a/packages/timeline-state-resolver/examples/testChangeTimelineQuickly.ts b/packages/timeline-state-resolver/examples/testChangeTimelineQuickly.ts index 346c613c21..c75082fa3d 100644 --- a/packages/timeline-state-resolver/examples/testChangeTimelineQuickly.ts +++ b/packages/timeline-state-resolver/examples/testChangeTimelineQuickly.ts @@ -13,7 +13,6 @@ const a = async function () { await tsr.addDevice('casparcg0', { type: DeviceType.CASPARCG, options: { - // useScheduling: true, host: '127.0.0.1', // port: 5250 }, diff --git a/packages/timeline-state-resolver/src/integrations/casparCG/$schemas/options.json b/packages/timeline-state-resolver/src/integrations/casparCG/$schemas/options.json index 8bff5482c7..c8e7114466 100644 --- a/packages/timeline-state-resolver/src/integrations/casparCG/$schemas/options.json +++ b/packages/timeline-state-resolver/src/integrations/casparCG/$schemas/options.json @@ -42,12 +42,6 @@ "ui:title": "Media retry interval", "ui:description": "Time between retries for media that could not be loaded on first try. Set to -1 to disable.", "default": 0 - }, - "useScheduling": { - "type": "boolean", - "description": "whether to use the CasparCG-SCHEDULE command to run future commands, or the internal (backwards-compatible) command queue", - "ui:title": "Use CasparCG Timecode Scheduler", - "default": false } }, "required": ["host"], diff --git a/packages/timeline-state-resolver/src/integrations/casparCG/__tests__/casparcg.spec.ts b/packages/timeline-state-resolver/src/integrations/casparCG/__tests__/casparcg.spec.ts index ccbd9a9766..edb05af02c 100644 --- a/packages/timeline-state-resolver/src/integrations/casparCG/__tests__/casparcg.spec.ts +++ b/packages/timeline-state-resolver/src/integrations/casparCG/__tests__/casparcg.spec.ts @@ -55,7 +55,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -134,7 +133,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -202,7 +200,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: false, fps: 50, }, commandReceiver: commandReceiver0, @@ -285,7 +282,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: false, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -359,7 +355,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -449,7 +444,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -529,7 +523,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -610,7 +603,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -727,7 +719,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -847,7 +838,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -986,7 +976,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -1092,7 +1081,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -1197,7 +1185,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -1298,7 +1285,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -1388,7 +1374,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: true, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -1473,7 +1458,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: false, retryInterval: undefined, // disable retries explicitly, we will manually trigger them }, commandReceiver: commandReceiver0, @@ -1601,7 +1585,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: false, retryInterval: undefined, // disable retries explicitly, we will manually trigger them }, commandReceiver: commandReceiver0, @@ -1731,7 +1714,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: false, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -1828,7 +1810,6 @@ describe('CasparCG', () => { type: DeviceType.CASPARCG, options: { host: '127.0.0.1', - useScheduling: false, }, commandReceiver: commandReceiver0, skipVirginCheck: true, @@ -1943,7 +1924,6 @@ describe('CasparCG', () => { // type: DeviceType.CASPARCG, // options: { // host: '127.0.0.1', -// useScheduling: false, // retryInterval: undefined, // disable retries explicitly, we will manually trigger them // }, // commandReceiver: commandReceiver0,