Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: atem-connection 2.0 #14

Closed
wants to merge 37 commits into from
Closed

wip: atem-connection 2.0 #14

wants to merge 37 commits into from

Conversation

Julusian
Copy link
Member

@Julusian Julusian commented Oct 24, 2019

Depends on nrkno/sofie-atem-connection#60

  • Refactor to support the v2 prereleases
  • Refactor resolvers to be simpler in their diffing, to reduce duplication (important as they all involve some casts to any)
  • Handle missing objects in the states better. If something is defined in either old or new then it should be resolved. If only defined in one, then the default should be used. This ensures the state gets reset back to default when being removed from the state.

TODO

  • implement resolveUpstreamKeyerMaskState
  • This should bump version to v1.0.0
  • Change MixEffect interface to better show that input+transition and programInput+previewInput are mutually exclusive

@Julusian Julusian changed the title wip: atem-connection strict-tsconfig branch. wip: atem-connection 2.0 Jan 17, 2020
@nytamin nytamin marked this pull request as draft May 13, 2020 09:20
@codecov-commenter
Copy link

codecov-commenter commented Jul 14, 2020

Codecov Report

Merging #14 into develop will decrease coverage by 1.03%.
The diff coverage is 98.41%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #14      +/-   ##
===========================================
- Coverage    99.33%   98.29%   -1.04%     
===========================================
  Files           18       17       -1     
  Lines          599      410     -189     
  Branches       110      101       -9     
===========================================
- Hits           595      403     -192     
- Misses           4        7       +3     
Impacted Files Coverage Δ
src/atemState.ts 91.66% <83.33%> (-8.34%) ⬇️
src/util.ts 88.88% <84.61%> (-11.12%) ⬇️
src/resolvers/media.ts 93.75% <91.66%> (-6.25%) ⬇️
src/resolvers/upstreamKeyers/index.ts 97.05% <96.42%> (-2.95%) ⬇️
src/defaults.ts 96.00% <100.00%> (-4.00%) ⬇️
src/index.ts 100.00% <100.00%> (ø)
src/resolvers/audio.ts 100.00% <100.00%> (ø)
src/resolvers/downstreamKeyer.ts 100.00% <100.00%> (ø)
src/resolvers/index.ts 100.00% <100.00%> (ø)
src/resolvers/macro.ts 100.00% <100.00%> (ø)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 78ef630...5ce4698. Read the comment docs.

@Julusian Julusian closed this Oct 12, 2020
@Julusian Julusian deleted the feat/v8-strict branch April 16, 2021 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants