Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links can't open in new tabs #56

Open
thomaswilburn opened this issue Feb 4, 2020 · 0 comments
Open

Links can't open in new tabs #56

thomaswilburn opened this issue Feb 4, 2020 · 0 comments

Comments

@thomaswilburn
Copy link

If we set the base in the head, we break internal links. However, if we don't, people complain that this page doesn't act like most NPR pages, in that links open in the current tab.

There are strong accessibility reasons not to automatically open links in a new tab, and I would argue that because the player here isn't on a PJAX page, we don't need to abide by the same expectations as the rest of the site. But we will need to have that discussion, and if I'm overruled, add JS to detect in-page links and scroll/replace the URL fragment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant