Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ads/audio player into custom tags #22

Open
thomaswilburn opened this issue Jan 17, 2020 · 0 comments
Open

Move ads/audio player into custom tags #22

thomaswilburn opened this issue Jan 17, 2020 · 0 comments
Milestone
Backlog

Comments

@thomaswilburn
Copy link

Since these have relatively well-defined positions and roles on the page, there's not really any good reason that we can't set them up using the same custom tags that we use for other embeds--and in fact, it would probably help in case we ever need more of either.
thomaswilburn pushed a commit that referenced this issue Jan 17, 2020
Make ads a custom element
c222523 
Allows us to have multiple ads if we feel like it. Currently only one shows up.
See also #22
@thomaswilburn thomaswilburn added this to the Backlog milestone Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@thomaswilburn