Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State page polishing tasks #51

Open
21 of 23 tasks
audreycarlsen opened this issue Feb 25, 2020 · 3 comments
Open
21 of 23 tasks

State page polishing tasks #51

audreycarlsen opened this issue Feb 25, 2020 · 3 comments

Comments

@audreycarlsen
Copy link
Contributor

audreycarlsen commented Feb 25, 2020

  • Initial state page view shows all races from most recent election day
  • Header icon alignment - flexible width?
  • Don't need show/hide option state-level results on county results pages; just show all state-level results by default
  • Show results for first county (alphabetically?) by default on county view
  • County dropdown should be alphabetical
  • "Most recent results" header on initial state page view
  • Incumbency key
  • Design for footer — include both credits and links to all the other state pages?
  • Office pages: Tables need headers
  • County results still indicate statewide winner - is this confusing? - YES. Moving to a bug.
  • Calendar page styling :)
  • Don't show county results links if there are no results
  • Hide state label on results tables if not on homepage
  • Pull AP source line out of results table and into footer
  • [County results page]: Add headers to statewide and county data sections
  • Scroll to county results on click
  • Refine header styling ("Most recent results," "District," etc)
  • Suppress county-level results on uncontested races (e.g. AL Dem. Senate race)
  • Back button to main state page and/or calendar view
  • Add "Other Candidates" language to footnote
  • Check everything on mobile
  • Better-looking mugshots
  • Not all states have counties - swap in different language for "See county results"
@audreycarlsen audreycarlsen changed the title State page clean-up tasks State page polishing tasks Feb 25, 2020
@thomaswilburn
Copy link

We will show counties when people click through, but I'd rather not show them by default on initial page load--those files can be very heavy, and I strongly suspect most people don't care.

@alykat
Copy link
Member

alykat commented Feb 26, 2020

@thomaswilburn point taken. and apologies: i had to reread what i wrote a few times to realize what i originally meant. i was talking about the state-level results tables atop the county results pages, not the county results themselves. and it doesn't appear to be an issue anymore anyway.

@thomaswilburn
Copy link

No worries!

thomaswilburn pushed a commit that referenced this issue Feb 28, 2020
Fixes #76
Adds header to county results re: #51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants