Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querying a big page number problem #7

Open
warent opened this issue Jan 23, 2017 · 4 comments
Open

Querying a big page number problem #7

warent opened this issue Jan 23, 2017 · 4 comments

Comments

@warent
Copy link

warent commented Jan 23, 2017

Seems that if the page reaches 10,000 then it stops working. Unsure if this is an API issue or a queries issue

npms-io/npms-api/issues/65

@satazor
Copy link
Member

satazor commented Mar 26, 2017

Hmm, I think we should limit the maximum number of elements to be retrieved. @bcoe what you think?

@bcoe
Copy link
Contributor

bcoe commented Mar 26, 2017

@satazor we enforce a limit on npm's side currently; because ElasticSearch enforces a hard limit at the database level which throws an exception (and is much uglier); it would probably be better to enforce this in queries and document it?

@satazor
Copy link
Member

satazor commented Mar 26, 2017

I agree, what do you think that max amount should be?

@satazor
Copy link
Member

satazor commented Mar 26, 2017

I will add a max value to the api endpoint but will keep this open because the validation should also be added here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants