Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auction house: reduce ability of bidder to make next bidder pay ~40K more gas #556

Open
davidbrai opened this issue Sep 1, 2022 · 0 comments
Labels

Comments

@davidbrai
Copy link
Collaborator

davidbrai commented Sep 1, 2022

This should be fixed in the next update to auction house contract:
code-423n4/2022-08-nounsdao-findings#382

Will probably use the mitigation proposed in the C4 issue:

        bool success;
        assembly {
            success := call(30000, addr, amount, 0, 0, 0)
        }
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant