Event was rejected by relay on publish but promise resolved

[yijiasu]

➜  relay git:(main) ✗ DEBUG=ndk:* ts-node seed/index.ts
  ndk:pool Connecting to 1 relays +0ms
  ndk:pool Relay ws://localhost:10801 connected +13ms
  ndk:relay:ws://localhost:10801 Publish failed Error: invalid: unexpected size for fixed-size tag
    at Timeout.handleNext (/Users/******/node_modules/.pnpm/[email protected][email protected]/node_modules/nostr-tools/lib/cjs/index.js:549:27)
    at listOnTimeout (node:internal/timers:573:17)
    at processTimers (node:internal/timers:514:7) 49c4aa1cf2ab81d99fd94d07ed53cb2f1da57bec307c6edd7a04ea469f49e80e +0ms
PUBLISH SUCCESS

Some code snippet:

  const ndk = new NDK({ explicitRelayUrls: ["ws://localhost:10801"] });

  const ndkEvent = new NDKEvent(ndk, json2);

  await ndk.connect();
  try {
    const out = await ndkEvent.publish();
    console.log("PUBLISH SUCCESS");
  } catch (error) {
    console.log("error");
    console.log(error);
  }

Version:

    "@nostr-dev-kit/ndk": "2.1.1",

[yijiasu]

Looks like it's resolved because of the event was an ephemeral one, so the error was ignored? Is there a reason we should swallow the error here instead of forwarding this exception to the user space?

[yijiasu]

Here:

ndk/ndk/src/relay/sets/index.ts

Lines 62 to 85 in 6821d40

	public async publish(event: NDKEvent, timeoutMs?: number): Promise<Set<NDKRelay>> {
	const publishedToRelays: Set<NDKRelay> = new Set();
	const isEphemeral = event.isEphemeral();
	// go through each relay and publish the event
	const promises: Promise<void>[] = Array.from(this.relays).map((relay: NDKRelay) => {
	return new Promise<void>((resolve) => {
	relay
	.publish(event, timeoutMs)
	.then(() => {
	publishedToRelays.add(relay);
	resolve();
	})
	.catch((err) => {
	if (!isEphemeral) {
	this.debug("error publishing to relay", {
	relay: relay.url,
	err,
	});
	}
	resolve();
	});
	});
	});