Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Set custom delimiter, if value in line is too long #126

Open
LHozzan opened this issue Feb 24, 2022 · 3 comments
Open

[Enhancement] Set custom delimiter, if value in line is too long #126

LHozzan opened this issue Feb 24, 2022 · 3 comments
Labels
enhancement New feature or request

Comments

@LHozzan
Copy link

LHozzan commented Feb 24, 2022

Hello.

This project looks very good and if is possible, I would like to suggest this enhancement.

In my case, we have in helm chart defined custom parameters for Kafkas topic, something like this:

kafka:
  # -- Set JVM parameters `-Xms` and `-Xmx` here.
  heapSize: "256M"
  # -- Persistent volume size.
  storage: "1Gi"
  topics:
    # -- Topics parameters
    config: "max.message.bytes=10000000,retention.bytes=134217728,retention.ms=3600000,message.timestamp.difference.max.ms=3600000,message.timestamp.type=LogAppendTime"

As you can see, when this is rendered by HelmDocs, as a result is very long line :(. All descriptions are hidden for only one long line and you must scroll to the right to see them.

Workaround for me looks like this:

kafka:
  # -- Set JVM parameters `-Xms` and `-Xmx` here.
  heapSize: "256M"
  # -- Persistent volume size.
  storage: "1Gi"
  topics:
    # -- Topics parameters
    # @default -- `max.message.bytes=10000000,` \ <br> `retention.bytes=134217728,` \ <br> `retention.ms=3600000,` \ <br> `message.timestamp.difference.max.ms=3600000,` \ <br> `message.timestamp.type=LogAppendTime`
    config: "max.message.bytes=10000000,retention.bytes=134217728,retention.ms=3600000,message.timestamp.difference.max.ms=3600000,message.timestamp.type=LogAppendTime"

It looks strange after rendering, but it is more readable. As a side problem is, that we lost automation :(. If somebody add / change some Kafka parameters and forget to reflect this change in @default flag, solution will be confusing.

My idea is, add parameter for set delimiter in that case. Something like this:

kafka:
  # -- Set JVM parameters `-Xms` and `-Xmx` here.
  heapSize: "256M"
  # -- Persistent volume size.
  storage: "1Gi"
  topics:
    # -- Topics parameters
    # @delimiter=,
    config: "max.message.bytes=10000000,retention.bytes=134217728,retention.ms=3600000,message.timestamp.difference.max.ms=3600000,message.timestamp.type=LogAppendTime"

After rendering I hope, that all settings from config string field will be in markdown on separated single line.

Of course, this is just a idea. If you consider it as a worthless, please, close this issue.

@jgkirschbaum
Copy link

I agree, this would be very helpful.

@norwoodj
Copy link
Owner

I think this is a good idea. I'd be happy to look at a PR, but at present, I don't have time to do the work myself. Maybe what you're asking for is related to this PR: #106?

@norwoodj norwoodj added the enhancement New feature or request label Apr 25, 2022
@LHozzan
Copy link
Author

LHozzan commented Apr 25, 2022

Hi @norwoodj .
Thank you for notified me for this PR. From my perspective looks good for column Key. But in this issue I would like something similar for Default column. It is possible to do same thing for column Default too, please? Of course, it can be done in different PR ...
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: No status
Development

No branches or pull requests

3 participants