Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping rook #1205

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Bumping rook #1205

merged 1 commit into from
Aug 24, 2023

Conversation

liranmauda
Copy link
Contributor

@liranmauda liranmauda commented Aug 22, 2023

Explain the changes

  • Run go get -u github.com/rook/rook@59e66edf92f7f611fd76f00ffd635a2718778c69
  • Bumping controller-runtime from v0.14.5 to v0.15.0
  • Replace deprecated wait.PollImmediateInfinite with wait.PollUntilContextCancel
  • Replaced deprecated "k8s.io/utils/pointer" with "k8s.io/utils/ptr"
  • Run go get -u github.com/gin-gonic/[email protected]

Issues: fixes:

  1. fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2184665
  2. fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2214481
  3. fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2228023

@liranmauda
Copy link
Contributor Author

@BlaineEXE @umangachapagain
running go get -u github.com/rook/[email protected] then go mod tidy removing the rook and leaving us with github.com/rook/rook/pkg/apis just verifying that I am not missing anything.
Can you have a look?

@liranmauda liranmauda changed the title Bumping rook to v1.12.1 Bumping rook to rook@59e66edf92f7f611fd76f00ffd635a2718778c69 Aug 24, 2023
@liranmauda liranmauda changed the title Bumping rook to rook@59e66edf92f7f611fd76f00ffd635a2718778c69 Bumping rook Aug 24, 2023
- Run `go get -u github.com/rook/rook@59e66edf92f7f611fd76f00ffd635a2718778c69`
- Bumping controller-runtime from v0.14.5 to v0.15.0
- Replace deprecated wait.PollImmediateInfinite with wait.PollUntilContextCancel
- Replaced deprecated "k8s.io/utils/pointer" with "k8s.io/utils/ptr"
- Run `go get -u github.com/gin-gonic/[email protected]`

Signed-off-by: liranmauda <[email protected]>

Update util.go
@liranmauda liranmauda merged commit 6726f40 into noobaa:master Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants