[GLACIER] Send x-amz-restore header as one single header instead of 2 headers with same name #8576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangledbytes
force-pushed
the
utkarsh/fix/amz-restore-header-2
branch
from
29fcfba to
e62683a
Compare
guymguym
approved these changes
Dec 4, 2024
…ith same name Signed-off-by: Utkarsh Srivastava <[email protected]>
tangledbytes
force-pushed
the
utkarsh/fix/amz-restore-header-2
branch
from
e62683a to
fed95e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
This PR changes the way we send
x-amz-restoreheader. Previously, we used to sendx-amz-restoreheader with 2 different values if the restore was completed. This works with most of the HTTP client but fails on some (it is valid from HTTP RFC perspective) but it is not the way AWS S3 sends this header hence the change.