Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supporting supplemental groups for accounts #7274

Open
romayalon opened this issue Apr 20, 2023 · 5 comments · May be fixed by #8552
Open

Supporting supplemental groups for accounts #7274

romayalon opened this issue Apr 20, 2023 · 5 comments · May be fixed by #8552
Assignees
@nadavMiz
Labels
NS-FS Type:Enhancement New suggestions for behaviours

Comments

@romayalon
Copy link
Contributor

romayalon commented Apr 20, 2023 •
edited
Loading

Environment info

  • NooBaa Version: master

Actual behavior

  1. Currently, nsfs config setting of account creation/update does not include supplemental groups configuration.
    When switching the user in FS_NAPI we only switch and restore to the user's uid gid.

Expected behavior

  1. Support supplemental groups on account creation/update with nsfs account config.
  2. When switching user in FS_NAPI, we should also switch groups to the supplemental groups received by the user using setgroups, and restore when restoring the uid gid.

More information - Screenshots / Logs / Other output
@romayalon romayalon added Type:Enhancement New suggestions for behaviours NS-FS labels Apr 20, 2023
@romayalon romayalon mentioned this issue Apr 20, 2023
Merged
2 tasks
@github-actions GitHub Actions
Copy link

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

@github-actions github-actions bot added the Stale label May 28, 2024
@romayalon
Copy link
Contributor Author

still not fixed, updating for stale bot

@romayalon romayalon removed the Stale label May 30, 2024
@github-actions GitHub Actions
Copy link

This issue had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed.

@github-actions github-actions bot added the Stale label Aug 29, 2024
@Neon-White
Copy link
Contributor

Bump

@github-actions github-actions bot removed the Stale label Aug 30, 2024
@guymguym
Copy link
Member

guymguym commented Sep 4, 2024

For distinguished user name we will use the following to get the supplemental groups list of the user -
https://man7.org/linux/man-pages/man3/getgrouplist.3.html

Here is the example of the linux coreutils groups cli tool that calls this library function internally - https://github.com/coreutils/coreutils/blob/master/src/groups.c

CC @madhuthorat @rkomandu

@nadavMiz nadavMiz self-assigned this Nov 13, 2024
@nadavMiz nadavMiz linked a pull request Nov 21, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadavMiz nadavMiz

Labels
NS-FS Type:Enhancement New suggestions for behaviours
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

NSFS | NC | add option to set account supplemental groups nadavMiz/noobaa-core
4 participants
@guymguym @Neon-White @nadavMiz @romayalon