Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s3_put_bucket_lifecycle validations should be more compatible with AWS #8426

Open
dannyzaken opened this issue Oct 1, 2024 · 0 comments
Open

Comments

@dannyzaken
Copy link
Contributor

Environment info

  • NooBaa Version: VERSION
  • Platform: Kubernetes 1.14.1 | minikube 1.1.1 | OpenShift 4.1 | other: specify

Actual behavior

  1. following Lifecycle changes - Allow all actions in put lifecycle configuration #8424, we accept all types of lifecycle configurations, including the deprecated Prefix field
  2. We should improve the validation of the configuration in the request. I noticed a few things that AWS does in their verifications, there might be more. e.g.:
    • if Prefix is sent, then the entire configuration is considered V1 , and any rule that contain a Filter will result in this error
      Filter element can only be used in Lifecycle V2.
      
    • if using V1, overlapping prefixes in different rules with the same action are not allowed. e.g.:
      Found overlapping prefixes 'dir/' and 'di' for same action type 'AbortIncompleteMultipartUpload'
      
      This is accepted in lifecycle V2
  3. We should consider how we want to handle these restrictions and if we want to follow it or be more permisive.
  4. in addition, we should add validations for all other actions before accepting the configuration

Expected behavior

Steps to reproduce

More information - Screenshots / Logs / Other output

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant