From ecb312909279fa313e456b8bd518cb1c1b479e46 Mon Sep 17 00:00:00 2001
From: shirady <57721533+shirady@users.noreply.github.com>
Date: Tue, 19 Nov 2024 13:20:11 +0200
Subject: [PATCH] add more details in Could not log bucket operation err + add
 comment in the code

Signed-off-by: shirady <57721533+shirady@users.noreply.github.com>
---
 src/endpoint/s3/s3_rest.js | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/src/endpoint/s3/s3_rest.js b/src/endpoint/s3/s3_rest.js
index d940981b2a..db7fc8aded 100755
--- a/src/endpoint/s3/s3_rest.js
+++ b/src/endpoint/s3/s3_rest.js
@@ -73,7 +73,7 @@ async function s3_rest(req, res) {
             try {
                 await s3_logging.send_bucket_op_logs(req, res); // logging again with error
             } catch (err1) {
-                dbg.error("Could not log bucket operation:", err1);
+                dbg.error("Could not log bucket operation (after handle_error):", err1);
             }
         }
     }
@@ -134,7 +134,7 @@ async function handle_request(req, res) {
         try {
             await s3_logging.send_bucket_op_logs(req); // logging intension - no result
         } catch (err) {
-            dbg.error("Could not log bucket operation:", err);
+            dbg.error(`Could not log bucket operation (before operation ${req.op_name}):`, err);
         }
     }
 
@@ -165,7 +165,9 @@ async function handle_request(req, res) {
     try {
         await s3_logging.send_bucket_op_logs(req, res); // logging again with result
     } catch (err) {
-        dbg.error("Could not log bucket operation:", err);
+        // GAP - (NC) since we don't have the bucket in bucket_namespace_cache we cannot get the bucket info
+        // after deleting the bucket
+        dbg.error(`Could not log bucket operation (after operation ${req.op_name}):`, err);
     }
 
 }