Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin: Minecraft查服 #2881

Closed
molanp opened this issue Aug 14, 2024 · 13 comments · Fixed by #2882
Closed

Plugin: Minecraft查服 #2881

molanp opened this issue Aug 14, 2024 · 13 comments · Fixed by #2882
Labels
Plugin Publish Plugin

Comments

@molanp
Copy link
Contributor

molanp commented Aug 14, 2024

PyPI 项目名

nonebot-plugin-mccheck

插件 import 包名

nonebot_plugin_mccheck

标签

[{"label":"Minecraft","color":"#ea5252"},{"label":"i18n","color":"#39c5bb"}]

插件配置项

No Response

@molanp molanp added the Plugin Publish Plugin label Aug 14, 2024
@noneflow
Copy link
Contributor

noneflow bot commented Aug 14, 2024

📃 商店发布检查结果

Plugin: Minecraft查服

✅ 所有测试通过,一切准备就绪!

详情
  • ✅ 项目 nonebot-plugin-mccheck 已发布至 PyPI。
  • ✅ 项目 主页 返回状态码 200。
  • ✅ 标签: Minecraft-#ea5252, i18n-#39c5bb。
  • ✅ 插件类型: application。
  • ✅ 插件支持的适配器: 所有。
  • ✅ 插件 加载测试 通过。

  • 💡 如需修改信息,请直接修改 issue,机器人会自动更新检查结果。
    💡 当插件加载测试失败时,请发布新版本后在当前页面下评论任意内容以触发测试。

    ♻️ 评论已更新至最新检查结果

    💪 Powered by NoneFlow

    @noneflow noneflow bot changed the title Plugin: nonebot-plugin-mccheck Plugin: Minecraft查服 Aug 14, 2024
    noneflow bot pushed a commit that referenced this issue Aug 14, 2024
    noneflow bot pushed a commit that referenced this issue Aug 15, 2024
    noneflow bot pushed a commit that referenced this issue Aug 15, 2024
    @yanyongyu
    Copy link
    Member

    插件的 scoped config 编写有误,如果你用了 scoped config,那你的 prefix 应该换个名字。另外通信那块用了同步 io,会阻塞机器人,请使用异步进行通信。

    @noneflow noneflow bot changed the title Plugin: Minecraft查服 Plugin: nonebot-plugin-mccheck Aug 15, 2024
    @molanp
    Copy link
    Contributor Author

    molanp commented Aug 16, 2024

    完成

    noneflow bot pushed a commit that referenced this issue Aug 16, 2024
    @noneflow noneflow bot changed the title Plugin: nonebot-plugin-mccheck Plugin: Minecraft查服 Aug 16, 2024
    @yanyongyu
    Copy link
    Member

    你的通信部分依然是同步 io,对于 dns 解析,请使用 asyncquery 和 asyncresolver。对于 socket 通信,请使用 asyncio

    @molanp
    Copy link
    Contributor Author

    molanp commented Aug 17, 2024

    你的通信部分依然是同步 io,对于 dns 解析,请使用 asyncquery 和 asyncresolver。对于 socket 通信,请使用 asyncio

    请检查更改是否符合要求
    25bbebfa5a320027e115727076c21534b2ff6eda

    @yanyongyu
    Copy link
    Member

    请删除你多余的一些代码,另外你的 socket 为什么不直接用 asyncio.open_connection 而是用 thread

    @molanp
    Copy link
    Contributor Author

    molanp commented Aug 18, 2024

    请删除你多余的一些代码,另外你的 socket 为什么不直接用 asyncio.open_connection 而是用 thread

    MineStat是一个第三方库,我只是附加到本地

    noneflow bot pushed a commit that referenced this issue Aug 18, 2024
    @molanp
    Copy link
    Contributor Author

    molanp commented Aug 18, 2024

    现已移除不必要的代码molanp/nonebot_plugin_mccheck/commit/b97d3ed0cd891d7a8d5e3ac9c88ea5fad75e52de

    noneflow bot pushed a commit that referenced this issue Aug 18, 2024
    @molanp
    Copy link
    Contributor Author

    molanp commented Aug 18, 2024

    字体文件似乎未正确包含,我会在近期进行修复

    noneflow bot pushed a commit that referenced this issue Aug 18, 2024
    @yanyongyu
    Copy link
    Member

    minestat 里大量使用了同步方法,建议还是改写成异步

    noneflow bot pushed a commit that referenced this issue Aug 19, 2024
    @molanp
    Copy link
    Contributor Author

    molanp commented Aug 20, 2024

    minestat 里大量使用了同步方法,建议还是改写成异步

    很难实现

    noneflow bot pushed a commit that referenced this issue Aug 20, 2024
    @molanp
    Copy link
    Contributor Author

    molanp commented Aug 21, 2024

    minestat 里大量使用了同步方法,建议还是改写成异步

    此项工作无法完成,已向minestat维护者提出请求

    @noneflow noneflow bot changed the title Plugin: Minecraft查服 Plugin: nonebot-plugin-mccheck Aug 21, 2024
    @molanp
    Copy link
    Contributor Author

    molanp commented Aug 21, 2024

    已使用其他方法实现异步socket

    @noneflow noneflow bot changed the title Plugin: nonebot-plugin-mccheck Plugin: Minecraft查服 Aug 21, 2024
    noneflow bot pushed a commit that referenced this issue Aug 21, 2024
    noneflow bot pushed a commit that referenced this issue Aug 22, 2024
    @noneflow noneflow bot closed this as completed in #2882 Aug 22, 2024
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    Plugin Publish Plugin
    Development

    Successfully merging a pull request may close this issue.

    2 participants